SNOW-1492090 Snowpipe streaming file master key id rotation #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ain/java/net/snowflake/ingest/streaming/internal/SnowflakeStreamingIngestClientInternal.java
Outdated
Show resolved
Hide resolved
...ain/java/net/snowflake/ingest/streaming/internal/SnowflakeStreamingIngestClientInternal.java
Outdated
Show resolved
Hide resolved
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
2 times, most recently
from
12d3fff
to
4b00b0a
Compare
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
from
7c8f5ed
to
7147d15
Compare
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
from
7147d15
to
77e4da5
Compare
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
from
42a23ca
to
200034b
Compare
There was a problem hiding this comment.
Thanks, @sfc-gh-bmikaili , as we discuss IRL, let's keep the old code path around, and only trigger the new code path when the encryption keys array from the server is not-null.
sfc-gh-bmikaili
force-pushed
the
bmikaili-SNOW-1492090-snowpipe-streaming-file-master-key-id-rotation
branch
from
f74b749
to
34968af
Compare
…pipe-streaming-file-master-key-id-rotation
…pipe-streaming-file-master-key-id-rotation
…pipe-streaming-file-master-key-id-rotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: SNOW-1492090
Moved the encryption logic out of channels. So now, encryption keys are stored in a per table (given by fullyqualifiedtablename) map on client level. This makes things simpler and allows us to update the keys on register blob.